Skip to content

Add forwarddiff compatibility and use it for linearisation#232

Merged
1-Bart-1 merged 3 commits intomainfrom
forwarddiff
May 5, 2026
Merged

Add forwarddiff compatibility and use it for linearisation#232
1-Bart-1 merged 3 commits intomainfrom
forwarddiff

Conversation

@1-Bart-1
Copy link
Copy Markdown
Member

@1-Bart-1 1-Bart-1 commented May 5, 2026

No description provided.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 May 5, 2026 11:32
Copy link
Copy Markdown
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty large change. Did you test if it has a significant advantage?

Comment thread examples/linearize_check.jl
Comment thread src/body_aerodynamics.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 94.53125% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/body_aerodynamics.jl 80.76% 5 Missing ⚠️
src/panel.jl 85.71% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@1-Bart-1
Copy link
Copy Markdown
Member Author

1-Bart-1 commented May 5, 2026

Significant advantage: linearization is more correct. Noise in the solutions significantly affected the quality of the jacobian. You can run examples/linearize_check.jl to see this.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 May 5, 2026 16:07
@1-Bart-1 1-Bart-1 merged commit d125463 into main May 5, 2026
8 of 9 checks passed
@1-Bart-1 1-Bart-1 deleted the forwarddiff branch May 5, 2026 16:09
@1-Bart-1 1-Bart-1 mentioned this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants